Apply new ruff rules #139
Merged
Apply new ruff rules #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
==========================================
- Coverage 65.12% 65.10% -0.03%
==========================================
Files 25 25
Lines 2644 2642 -2
Branches 417 415 -2
==========================================
- Hits 1722 1720 -2
Misses 811 811
Partials 111 111 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
DimitriPapadopoulos
force-pushed
the
ruff
branch
2 times, most recently
from
ac4ff83 to
c9a6902
Compare
C409 Unnecessary list comprehension passed to `tuple()` (rewrite as a generator)
C419 Unnecessary list comprehension
UP008 Use `super()` instead of `super(__class__, self)`
RUF022 `__all__` is not sorted
RUF023 `__slots__` is not sorted
PERF401 Use a list comprehension to create a transformed list
FURB188 Prefer `removeprefix` over conditionally replacing with slice.
SIM401 Use `.get()` instead of an `if` block
ISC001 Implicitly concatenated string literals on one line
DimitriPapadopoulos
force-pushed
the
ruff
branch
from
c9a6902 to
58fbf88
Compare
effigies
approved these changes
Nov 23, 2024
Co-authored-by: Chris Markiewicz <[email protected]>
Co-authored-by: Chris Markiewicz <[email protected]>
effigies
added a commit
that referenced
this pull request
Dec 19, 2024
24.1.0 (December 18, 2024) New feature release in the 24.1.x series. This release includes a migration of most if not all reporting interfaces from NiWorkflows. This release also supports Python 3.13 and Numpy 2. * ENH: Finalize migration of reporting interfaces (#71) * ENH: Allow figures in session folder (#138) * RF: Replace nireports.data.Loader with acres.Loader (#142) * STY: Apply new ruff rules (#139) * MAINT: Add tox.ini, test minimum dependencies (#141)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.